Skip to content

tcp_keepalive fix#56

Closed
michaelfeil wants to merge 1 commit intohuggingface:mainfrom
michaelfeil:patch-1
Closed

tcp_keepalive fix#56
michaelfeil wants to merge 1 commit intohuggingface:mainfrom
michaelfeil:patch-1

Conversation

@michaelfeil
Copy link
Copy Markdown

I believe the current requests are downloaded from http/1, so setting the http/2 only-feature of the crate seems like an odd way to set this feature.

Feel free to ignore this PR if not helpful.

@leo-ars
Copy link
Copy Markdown

leo-ars commented Apr 30, 2025

@michaelfeil I also noticed that the request were HTTP/1.1 but I think that implementing APLN is a better fix than using tcp_keepalive(), what do you think? To really implement HTTP/2 properly.

I made a pull request here: #73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants